Skip to content

docs: replace em dashes and curly quotes in CLI and component doc prose - #5354

Merged
cixzhang merged 3 commits into
mainfrom
navi/docs/slop-46
Aug 24, 2026
Merged

docs: replace em dashes and curly quotes in CLI and component doc prose#5354
cixzhang merged 3 commits into
mainfrom
navi/docs/slop-46

Conversation

@josephfarina

Copy link
Copy Markdown
Contributor

What

Replace AI-slop typographic tells (em dashes and curly apostrophes) in doc prose across the CLI and component docs. Prose strings only; no technical claim was reworded and no information removed.

Files and recasts:

  • packages/cli/api/docs/docs.doc.mjs — em dash aside to commas
  • packages/cli/api/template/template.doc.mjs — aside to parentheses; sentence break to period
  • packages/cli/api/theme/themeTemplate.doc.mjs — list intro to colon/comma; receipt aside to period
  • packages/cli/clients/cli/commands/theme-template.doc.mjs — same as above
  • packages/cli/assets/docs/typography.doc.mjs — em dash to colon; ellipsis "..." spelled as "and so on"; paired aside to parentheses
  • packages/cli/foundation/response/response-types.doc.mjs — two receipt asides to periods
  • packages/core/src/Selector/Selector.doc.mjs — sizing aside to comma
  • packages/core/src/SideNav/SideNav.doc.mjs — isSelected aside to colon; label clause to semicolon (3 overlays each)
  • packages/core/src/hooks/useContainerReveal.doc.mjs — three em dash asides to colons
  • packages/core/src/Field/Field.doc.mjs — curly apostrophe to straight (2)
  • packages/core/src/Thumbnail/Thumbnail.doc.mjs — curly apostrophe to straight

Chinese CJK double em dash, numeric ranges, code comments, and Component — Variant labels were left as-is.

Checklist

  • pnpm --filter @astryxdesign/core typecheck:docs passes
  • pnpm exec tsc --project packages/cli/tsconfig.template-docs.json --noEmit clean for edited files (only the pre-existing theme.template.ts:83 TS2307 remains, untouched here)
  • Every edited .doc.mjs parses (import() check)
  • CLI --props and --lang dense output verified for Selector and SideNav
  • Prose strings only; meaning preserved

Night Watch — Doc Reviewer

Recast em dashes as colons, commas, semicolons, or parentheses and
straighten curly apostrophes across docs, template, theme, typography,
response-type, Selector, SideNav, useContainerReveal, Field, and
Thumbnail doc prose. Prose strings only; meaning preserved.

Found during Night Watch doc review.
@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 24, 2026 4:17am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 23, 2026
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

Field (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 758 -
Complexity N/A Very High (48) -
Selector (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1594 -
Complexity N/A Very High (168) -
SideNav (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1965 -
Complexity N/A Very High (186) -
Thumbnail (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 307 -
Complexity N/A Very High (37) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: 1 accessibility violation(s) found — 1 serious.

Thumbnail - 1 issue(s)
  • 🟠 serious: Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds
    • Rule: color-contrast · Affects 2/12 stories · Learn more
    • WCAG: 1.4.3 (Level AA)

Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 23, 2026

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The response-types table in the CLI README is generated from these descriptions — pnpm -F @astryxdesign/cli readme and commit, then the red test goes green.

[Reviewed by Robohands]

@cixzhang
cixzhang enabled auto-merge (squash) August 24, 2026 01:24
@cixzhang cixzhang closed this Aug 24, 2026
auto-merge was automatically disabled August 24, 2026 04:08

Pull request was closed

@cixzhang cixzhang reopened this Aug 24, 2026
# Conflicts:
#	packages/cli/README.md
@cixzhang
cixzhang enabled auto-merge (squash) August 24, 2026 04:15
@cixzhang
cixzhang merged commit 20bae6c into main Aug 24, 2026
19 checks passed
github-actions Bot added a commit that referenced this pull request Aug 24, 2026
@github-actions
github-actions Bot deleted the navi/docs/slop-46 branch August 24, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants